charlescd icon indicating copy to clipboard operation
charlescd copied to clipboard

Deploy incremental

Open bCatanant opened this issue 4 years ago • 3 comments

Signed-off-by: Katanant [email protected]

bCatanant avatar Aug 23 '21 19:08 bCatanant

Codecov Report

Merging #1409 (bb386dc) into main (d12f3d8) will decrease coverage by 0.01%. The diff coverage is 90.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1409      +/-   ##
============================================
- Coverage     78.47%   78.46%   -0.02%     
- Complexity     2258     2269      +11     
============================================
  Files          1284     1287       +3     
  Lines         17876    17946      +70     
  Branches       1642     1654      +12     
============================================
+ Hits          14029    14082      +53     
- Misses         3371     3382      +11     
- Partials        476      482       +6     
Flag Coverage Δ
butler 89.14% <87.50%> (+0.33%) :arrow_up:
moove 75.12% <100.00%> (-0.09%) :arrow_down:
ui 80.05% <87.50%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oyments/validations/create-deployment-validator.ts 100.00% <ø> (ø)
ui/src/modules/Circles/Comparation/Item/index.tsx 51.96% <ø> (ø)
...app/v2/core/logs/console/console-logger.service.ts 85.00% <66.66%> (+2.39%) :arrow_up:
...operator/use-cases/reconcile-deployment.usecase.ts 80.00% <75.00%> (-0.27%) :arrow_down:
ui/src/modules/Circles/Release/Create/index.tsx 70.73% <75.00%> (-0.33%) :arrow_down:
...deployments/use-cases/create-deployment.usecase.ts 96.51% <100.00%> (+0.08%) :arrow_up:
.../v2/operator/use-cases/reconcile-routes.usecase.ts 100.00% <100.00%> (ø)
.../deployment/impl/CreateDeploymentInteractorImpl.kt 96.87% <100.00%> (ø)
...tion/deployment/request/CreateDeploymentRequest.kt 100.00% <100.00%> (ø)
...oove/infrastructure/service/DeployClientService.kt 97.56% <100.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d12f3d8...bb386dc. Read the comment docs.

codecov-commenter avatar Aug 23 '21 19:08 codecov-commenter

@guilhermemartinsdeoliveirazup I added an explanation about the warning. About the trailing comma, I think it can be inserted as a lint rule in the lint task, so it can be standardized across all modules.

thallesfreitaszup avatar Sep 23 '21 14:09 thallesfreitaszup

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
RSA Private Key 2c8ec896213a388d478c76f8785883b6ab79b83a butler/kind-config.yaml 14:09 September 20th, 2021 View secret
RSA Private Key 38f53ecc1d02ed2c830dfac0c720218bcfac4c54 butler/kind-config.yaml 14:10 September 20th, 2021 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks

gitguardian[bot] avatar Nov 04 '21 19:11 gitguardian[bot]