moviepy icon indicating copy to clipboard operation
moviepy copied to clipboard

Fix typo in docstring

Open ricqosu opened this issue 2 years ago • 2 comments

Fixed typo in doc string

ricqosu avatar Nov 23 '23 08:11 ricqosu

Looks correct.

luzpaz avatar Feb 08 '24 14:02 luzpaz

While improving a docstring's contents, it'd be great to simultaneously also fix issues with its formatting, see PEP 257.

keikoro avatar Feb 10 '24 20:02 keikoro

Looks fine. We can review and close minor PRs.

kishcs avatar Mar 02 '24 04:03 kishcs

@kishcs That's kind of a weird thing to say to an admin as a random user. The no. of mystery reviews on this non-essential PR by unrelated 3rd parties makes this increasingly look like an excercise to me. It's def. reminiscent of Hacktoberfest a few years back, when people put quantity of contributions over quality.

We can review and close minor PRs.

We can also learn from suggestions on how to improve the quality of our contributions, especially when that requires very little effort.

keikoro avatar Mar 04 '24 15:03 keikoro

Definitely. I was just telling to reduce the PR count and to narrow down the focus on real issues and PRs. In case it's no quality, you can reject it too. 🙏

kishcs avatar Mar 04 '24 15:03 kishcs

The chronology of actions taken on this PR and OP not showing interest in improving their submission is fascinating, in any case. Guess I wasn't too far off with what I said last.

keikoro avatar Mar 05 '24 19:03 keikoro