ZsoltMolnarrr
[1.21.1][Connector] Spell Registry fails to encode, when adding too many spells
This is more of a Sinytra Connector problem but a temporary patch can be done by compressing the spell registry like https://github.com/falsidge/SpellEngine/commit/a98cc718b54fc9e3d99562959d81b06381aeadd7 This is the log https://mclo.gs/qV99lFR
I have tested Spell Engine on Sinytra Connector several times, since the Registry sync was rewritten. I am 100% it was working, this issue doesn't seem to be a Spell Engine problem, likely a bug in Connector.
Does the problem go away with less class mods installed? Does maybe 1 particular class mod cause the problem? What exactly is the scenario to reproduce this issue? Does this happen on Fabric also?
This is 100% a connector issue but it can be mitigated slightly with a patch that compresses the spell registry during encoding.
Yes, this problem goes away with less class mods installed.
~~It's not one specific class mod.~~
This problem specifically happens with connector.
I will try it on different connector versions but I wanted to answer the above first.
Actually it seems to happen with specifically elemental wizards with connector. It does not happen in fabric.
https://github.com/ProfessorFichte/Elemental-Wizards/issues/4 https://github.com/Sinytra/Connector/issues/1773
Spell engine can be patched to compress the spell registry to mitigate this, however.
Seems like it is not the whole registry that is too large, but an individual spell data file is too large. Your suggested solution of using zip could work, however it adds additional computation for the server side, which I am a little worried about.
The encoded entry needs to be smaller thats for sure.
The first step to achieve this is, is to avoid using base64 encoding. While it doesn't guarantee this doesn't happen again, it seems to fix this particular issue with Elemental Wizards, while also boosting CODEC performance.
This fix will be released in about a week. Thank you for the report, and details!
This issue has been fixed, in the upcoming 1.7 version. 1.7 is still being worked on, so I request additional patience on the matter.
In the mean time I can tell, that one specific oversized spell is triggering this problem, added by Elemental Wizards.