[1.21.1] Sophisticated backpack - Off-hand item deletion

[amzelee]

Minecraft version - 1.21.1 Mod loader - NeoForge Mod version - 2.1.3 I am using the latest version available - Yes

Describe the bug Similar to #421 and #444, when using the advanced refill backpack upgrade feature from sophisticated backpacks to refill the offhand slot while holding a 2 handed weapon, it will cause the item to permanently disappear.

To Reproduce Steps to reproduce the behavior: 0. Hold a 2 handed weapon

1. Set the SB advanced refill upgrade filter to refill the off hand slot.
2. Watch as the backpack refills your off hand slot but the item disappears and not exist in the off hand.

Expected behavior That the item will appear in the off hand when the 2 handed weapon is no longer held.

Screenshots or video recordings I will attach a video recording of what occurs in a few hours. I am currently unable to do so as of the moment.

Additional context A similar context from a different mod: Simply Swords, stated by the author of Sophisticated backpack here.

[ZsoltMolnarrr]

As far as I see, there is nothing I can do to fix these issues, however there is an easy fix others may implement for compatibility with Better Combat.

To make the Two-Handed logic full functional in all scenarios, Better Combat needs to capture player.getOffHandStack(). Instead of using this function, other mods may call instead: player.getInventory().offHand.get(0) which returns the unfiltered offhand itemstack. Relying on this most likely will avoid any such issues.

This issue as is, is non-actionable.

[amzelee]

Hello again. I brought this suggestion up to the author of sophisticated backpacks here. I believe their take on the situation with the compatibility is reasonable. Would it be possible to accomodate a "cover fix" by simply adding a toggle-able config that disables the ivalidation of the off-hand when holding a 2 handed weapon? Forgive me if that suggestion or idea sounds dumb. I have no experience in modding.

[ZsoltMolnarrr]

I replied to the linked conversation.

Besides the workaround that I suggested, there is no known technically available solution as I know of.

disables the ivalidation of the off-hand when holding a 2 handed weapon

This would violate gameplay integrity, allow players to disable the penalty of 2 handedness at will (to dual wield large weapons). This is not an option to be implemented.

If this issue is not resolved, unfortunately I will have to add breaks flag against Sophisticated Backpack.

I am awaiting for further responses tho.

[amzelee]

I understand. Assuming a compromise cannot be made between the mods, a "breaks" flag or incompatibility indication would at least alert future users who plan to combine the two together. Thank you for your time.

[P3pp3rF1y]

I have just released a new version of SB with the change suggested here so the deletion should no longer happen

[ZsoltMolnarrr]

Thank you for the cooperation, much appreciated!