BetterCombat icon indicating copy to clipboard operation
BetterCombat copied to clipboard

Changed swingthurgrass to allow for players to break "grass" with a weapon when there are no targets in range

Open paypur opened this issue 9 months ago • 1 comments

I find myself holding weapon a lot and trying to clear torches is vert annoying with better combat, especially when all tools are tagged as weapons, where I have to switch to some random item to break torches. I think change this makes much sense than always or never swinging through grass. I can also make this another config if you want.

paypur avatar Mar 22 '25 22:03 paypur

Hello, Thanks for the submission. Currently very busy, will take a good look as soon as I am free.

ZsoltMolnarrr avatar Mar 30 '25 18:03 ZsoltMolnarrr

What about this existing config: isAttackInsteadOfMineWhenEnemiesCloseEnabled ?

Doesn't it do exactly the same already?:)

ZsoltMolnarrr avatar Apr 23 '25 19:04 ZsoltMolnarrr

Apologies no, the mentioned config option doesn't do what this PR suggests.

Thank you for the recommendation. Added this feature with a simplified implementation.

It is behind a client config option, currently disabled by default. The default may change over time based on user feedback.

ZsoltMolnarrr avatar Apr 24 '25 11:04 ZsoltMolnarrr

Hi, thank you for implementing this. I know maintaining multiple versions can be a hassle but can this feature to be backported to 1.20.1?

paypur avatar Apr 25 '25 04:04 paypur