BetterCombat icon indicating copy to clipboard operation
BetterCombat copied to clipboard

Modifying weapon/tool stats using attribute modifiers or the "Property Modifier" mod swaps the order of weapon/tool stat text

Open TyrionReyukra opened this issue 1 year ago • 0 comments

Minecraft version - 1.19.2 Mod loader - Forge Mod version - "bettercombat-forge-1.7.0-1.19" I am using the latest version available - According to the curseforge launcher, yes

Describe the bug I reported this on the "Property Modifier" discord and was suggested to also report it here.

Modifying an items attack damage value or attack speed value causes them to be swapped in the item tooltips. The placement is reversed regardless if the attack range tooltips are configured to be displayed or not.

Vanilla: Attack Damage Attack Speed Attack Range

Modified: Attack Speed Attack Damage Attack Range

I've attached screenshots of a modified wooden axe, and an unmodified stone axe, each wth the attack speed tooltip enabled and disabled respectively.

The placement swapping of the tooltips doesn't happen unless Better Combat is installed. Some odd things I don't really understand start to happen when modifying values to certain numbers.

I modified a wood axe to have 50 damage as a test, but when reduced to a more reasonable 3 damage, the order is back to normal. Using Property Modifier to set the attack speed of all axes to 0.8, including ones that are already 0.8, reversed the display order again.

To Reproduce Steps to reproduce the behavior:

  1. Install the "Property Modifier" mod by "IchHabeHunger54" along with Better Combat Curseforge link to Property Modifier: https://www.curseforge.com/minecraft/mc-mods/property-modifier
  2. Use its config to modify a weapon stat
  3. Tooltip text order of "Attack Damage" and "Attack Speed" are swapped around

Expected behavior Modifying item stats to simply change the damage/attack speed value, not swapping the placement of the text.

Additional context I've also tried modifying weapon damage using "IBE Editor" by "skyecodes", with a similar result. The placement of attack damage and attack speed are swapped in the tooltip.

IchHabeHunger54 has also said to provide a link to Property Modifiers GitHub, as well as the discord to assist in resolving the issue GitHub link: https://github.com/IchHabeHunger54/PropertyModifier/issues Discord link: https://discord.gg/Gx9SBKWCag

Screenshots image_2023-05-08_182632455 image_2023-05-08_182639420 image image

TyrionReyukra avatar May 08 '23 23:05 TyrionReyukra