material-decoration icon indicating copy to clipboard operation
material-decoration copied to clipboard

Non-empty borders should be respected by theme

Open ancwrd1 opened this issue 4 years ago • 3 comments

If the borders are set to something other than None the theme selection color overlaps the top border. See attached screenshots:

menu

button

ancwrd1 avatar Mar 08 '21 16:03 ancwrd1

2021-03-08___11-30-29

The outline is drawn on top of the hovered rect.

I'm not sure if adding .adjusted(0, 1, 0, 0) to the button's background fill would look much better.

https://github.com/Zren/material-decoration/blob/master/src/Button.cc#L221

Zren avatar Mar 08 '21 16:03 Zren

I tried it with .adjusted(0, 2, 0, 0) and it does look better I think:

Screenshot_20210308_182206

ancwrd1 avatar Mar 08 '21 17:03 ancwrd1

Also reducing one pixel from the bottom makes the menu hovering look slightly better.

ancwrd1 avatar Mar 08 '21 17:03 ancwrd1