Chris Holland
Chris Holland
Just leave them all. This is pretty much a non-issue.
Any logging in master is production logging. If you have dev/debug logging, it should be removed or commented out before being merged. I agree that there should be more logging...
> apparently you are the only one with access to 'these so called logs'. Which makes it difficult to know for those only used to logging output in dev environments....
Underscore has `_.once()` btw.
There should probably also be a constraint on the db. ``` js var UserSchema = new Schema({ //--- Data name: { type: String, unique: true }, ``` http://mongoosejs.com/docs/api.html#schematype_SchemaType-unique
Starting to implement this: https://github.com/Zren/OpenUserJS.org/commit/4f33df7cbc0b47ba8957bf6a11f3961a90ff9cb9
Normally you wouldn't base the filename/keys based on the username/scriptname. Create an id for each source code and store it in the Script model. If we wanted to future proof...
> Ability to Sort order Groups by size. Requires a new property in the Group schema. There's no way around that.
> An option right now is to manually reimport again until this gets defined and resolved. ~~Does redelivering the webhook (the button in the github screenshot) 1m after fail work?...
I just realized our code does use ghUsername elsewhere. https://github.com/OpenUserJs/OpenUserJS.org/blob/aa845e556015f2014219085cca2bf2ecc9c098de/controllers/scriptStorage.js#L435 So yep, your account won't be sync to the org, which causes it to not notice it.