crusader
crusader copied to clipboard
Request for change to version number procedure
Thanks for bumping to version 0.1.0 - you deserve it for all this good work :-)
BUT... I am going to state (one final time) why I am being so insistent about the version number.
- The log files for the builds right now all say
0.1.0. But they're not. They are almost0.1.0 - Someday soon, you are going to tag a build that's actually
0.1.0. The version number in the logs will be correct. - And then, moments after congratulating yourself on the good work, you're going to make another commit, and that build won't be
0.1.0- it'll be something else.
(As I've said before), my suggestion is to add -testing (or alpha or beta or ReleaseCandidate1 or some other string) to the version in the .toml files. As soon as you tag a release, you should bump the version to N+1, and add -testing so that we can tell the difference.
Two other considerations:
-
There are a lot of places the version shows up - five, I think. It's a pain in the patootie to update them consistently. Are there tools (github actions?) to set it once and update multiple files from a 'master'? Here are the
namesI find:crusadercrusader-libcrusader-guicrusader-gui-libcrusader-android
-
During intense debugging periods, it's a pain to keep digging out the git commit hash to report the version I was actually using. It would be fun to have a log file show
... version 1.2.3-testing (abcdef)so that I don't screw up and mistype the commit hash. (As I suggested before), it would probably only be necessary when the version contained-testing.
Thanks for listening.
Thanks for the -dev and git hash.
I'm assuming that you'll release 0.1.0 with a 0.1.0 version string, then create a 0.1.1-dev (or similar) for follow-on versions. I'm closing this.
@Zoxc Thanks for adopting this procedure. (At least that's what I think you've done - the current dev version is 0.1.1-dev, which matches what I hoped for...)
I note when compiling the latest, that the crusader-lib et al are still labeled 0.1.0. Is this intended? Thanks again.
src % cargo build --release
Compiling crusader-lib v0.1.0 (/Users/richb/github/crusader/src/crusader-lib)
Compiling crusader-gui-lib v0.1.0 (/Users/richb/github/crusader/src/crusader-gui-lib)
Compiling crusader-gui v0.1.0 (/Users/richb/github/crusader/src/crusader-gui)
Compiling crusader v0.1.0 (/Users/richb/github/crusader/src/crusader)
Finished `release` profile [optimized] target(s) in 16.26s
Yes. 0.1.0 is the default Cargo crate version and these will just stay at that version.
Thanks! Closing this...