When editing a monitor, using RTSP, host cannot contain random punctuation

[connortechnology]

However the password might have punctuation in it.

We need to be consistent on all the various methods, including the control tab.

I think username/password should be separate fields, that way we can actually do useful input validation.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[SteveGilvarry]

Use Username and Password fields already in the db and just do this.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[connortechnology]

I hate you stale bot.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[GlenCooper]

Just commenting because I've reached this point, but need sleep (sorry). Hopefully this comment will keep the stale-bot at bay for a little longer.

[parvit]

Hi all, i'm working on this and i've just got the system working from source. I'll let you know as i have a change ready.

[parvit]

@connortechnology I've added the PR responding to your request.

[parvit]

Hello, is there any feedback on this?

[parvit]

@connortechnology Thanks for merging the PR, if we may close this ticket it would allow me to claim the bounty.

As a side note: I would like to work also on #355, but it's locked so i don't know if i can proceed, can we unlock that one? thanks.

[connortechnology]

I don't see anything locked about #355. You might want to discuss your approach on it before digging in too far. Would be great to have it done though.

I've modified your code a bit. in php8 passing null to a lot of functions generates errors. Also I'm not sure strlen is the most efficient way to determine if a string is empty or not. I also took out the setting of auth_type in ffmpeg. It shouldn't be necessary and is just generating errors in the logs.

[parvit]

This is what i see from my side on #355

[connortechnology]

Okay it is unlocked.

[parvit]

It worked, thanks.