zoneminder icon indicating copy to clipboard operation
zoneminder copied to clipboard

favicon.ico with PNG content

Open onlyjob opened this issue 5 years ago • 9 comments

There is an inconsistency between file name and its content:

$ file web/api/app/webroot/favicon.ico
web/api/app/webroot/favicon.ico: PNG image data, 32 x 32, 8-bit colormap, non-interlace

onlyjob avatar Mar 10 '20 22:03 onlyjob

This file comes with cakephp I think...

connortechnology avatar Mar 10 '20 22:03 connortechnology

There is another file web/api/lib/Cake/Console/Templates/skel/webroot/favicon.ico that is definitely came from CakePHP so the web/api/app/webroot/favicon.ico appears to be a copy of that file since they both have identical md5sum.

web/graphics/favicon.ico have no such problem.

onlyjob avatar Mar 10 '20 23:03 onlyjob

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 10 '20 02:05 stale[bot]

@stale bot practices disrespectful and inefficient issue management approach. :(

onlyjob avatar May 10 '20 12:05 onlyjob

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 10 '20 05:07 stale[bot]

So I havn't addressed this because I'm not sure what the correct course of action is. We could replace it with a png version... but this file comes with cakephp. It's really cakephp's problem. We really should update our cakephp code to version 3, which I believe allows us to get rid of all cakephp boilerplate including this file.

connortechnology avatar Jul 10 '20 13:07 connortechnology

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 10 '21 19:03 stale[bot]

This might get fixed with us updating cakephp for fix php8. Reminder to check

connortechnology avatar Mar 10 '21 21:03 connortechnology

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 07:04 stale[bot]