pycrypto icon indicating copy to clipboard operation
pycrypto copied to clipboard

Published 20 hours ago • verified publisher icon Zokrates

Should we determine use which ModSqrt

Open zyfrank opened this issue 5 years ago • 1 comments

https://github.com/Zokrates/pycrypto/blob/e0c544a3f8f6719d7391ff0b16e6b8c9c3e7798c/zokrates/babyjubjub.py#L124 As we know, an element of Fp may have several ModSqrt, for example 4 of F5 has two: 2, 3. should we determine use which ModSqrt? otherwise this will lead to conflict with other implementation(because they can choose another ModSqrt)

zyfrank avatar Jun 17 '19 03:06 zyfrank

What I mean is that ModSqrt can have two roots (or none), maybe we should define use the smaller or bigger?

zyfrank avatar Jun 17 '19 03:06 zyfrank