rls-vs2017 icon indicating copy to clipboard operation
rls-vs2017 copied to clipboard

Install component does not work

Open TrianglesPCT opened this issue 7 years ago • 15 comments

I was going to try this out, but it refuses to install--

I had rust nightly so after reading the other messages here I switched to stable(by making it the default with rustup).

Same result as before. It brings up the Install button. I click it. It says: could no install one of the required rls components

vs2017 15.9.6

TrianglesPCT avatar Feb 15 '19 17:02 TrianglesPCT

Interesting, I'll look into it. This might be due to the renaming of rls-preview to rls.

ZoeyR avatar Feb 15 '19 17:02 ZoeyR

I just pushed an update that should have fixed this. Would you mind downloading the latest version (0.4.6) and testing?

ZoeyR avatar Feb 16 '19 03:02 ZoeyR

I grabbed the update, but it still does the same thing

Is there a log file that maybe shows more info about what is going wrong?

TrianglesPCT avatar Feb 16 '19 07:02 TrianglesPCT

I have the same issue

bugproof avatar Feb 23 '19 11:02 bugproof

I have the issue as well.

Visual Studio 2017 15.9.7 with the latest plugin from the marketplace.

I started Visual Studio with admin rights, no change.

mmttim avatar Mar 01 '19 20:03 mmttim

I'm guessing this has something to do with it. untitled

ghost avatar Mar 01 '19 22:03 ghost

@v3Monsta unless they changed rustup that shouldn't actually be the issue. installing rls-preview still works from my testing but in newer versions of Rust the module is reported at "rls". When I get home tonight I'll test it just to make sure.

ZoeyR avatar Mar 01 '19 22:03 ZoeyR

It could also be caused by the installed Nightly build missing the RLS component as described here. Perhaps more verbose errors on attemping to install the components could help with this.

Jaggernaut555 avatar Mar 02 '19 04:03 Jaggernaut555

That seems far more likely than my guess and I'll see if downgrading to a build of nightly that includes the RLS fixes my issue. However, while the current rustup does autocorrect rls-preview to rls, it might still be worth changing to avoid breaking if rustup changes in the future.

Edit: Doesn't look like it's because the RLS is missing from nightly. I installed nightly-2019-02-27 and the extension is still having a hard time.

ghost avatar Mar 02 '19 05:03 ghost

The extension by default explicitly tries to use nightly, so you'd need to change that under Tools > Options > Rust. Of course, that dialog was broken for me in VS 2017 15.9.12, possibly due to a VS bug or breaking change - I've created a PR to fix that: https://github.com/dgriffen/rls-vs2017/pull/24

I've been switching to stable and that seems to work.

MaulingMonkey avatar May 31 '19 18:05 MaulingMonkey

I've been switching to stable and that seems to work.

Not for me: Screen Shot 2019-06-17 at 1 24 57 PM

Screen Shot 2019-06-17 at 1 30 32 PM

mouse07410 avatar Jun 17 '19 17:06 mouse07410

@mouse07410 what happens if you run rustup component add rls --toolchain stable manually?

ZoeyR avatar Jun 17 '19 17:06 ZoeyR

Screen Shot 2019-06-17 at 1 47 43 PM

And then the same thing/problem/error in the VS2017.

Update

Note, that on Windows it happens with both VS2017 and VS Code. On other patforms, VS2017 is not viable at all, but VSCode works perfectly. Everything gets installed, everything works. So, it seems to be Windows-related.

mouse07410 avatar Jun 17 '19 17:06 mouse07410

@mouse07410 that is very strange, if it happens in VS Code as well it may be better to file a bug there since they have more resources to triage the bug and I can then look into what their fix was.

ZoeyR avatar Jun 18 '19 20:06 ZoeyR

Let me double-check the VSCode.

mouse07410 avatar Jun 18 '19 22:06 mouse07410