unstract icon indicating copy to clipboard operation
unstract copied to clipboard

FEAT: Added "Run All Prompts" with Concurrent API Request Queuing Mechanism

Open tahierhussain opened this issue 1 year ago • 3 comments

What

  1. Added a "Run All Prompts" button to execute all prompts across all LLM profiles for the currently selected document.
  2. Added a "Run All Prompts" button to execute all prompts across all LLM profiles for all documents.
  3. Refactored the code to support concurrent API requests when running multiple prompts.

Why

To enhance the user experience, we implemented "Run All" buttons, allowing users to execute prompts across multiple LLM profiles and documents. However, when too many concurrent API requests were triggered, the application's performance degraded significantly. This occurred because browsers typically handle only 6-7 concurrent API calls at a time, leaving the remaining requests in a pending state. As a result, this increased memory usage and caused the application to slow down.

How

A queuing mechanism has been introduced to limit the number of concurrent API requests to a maximum of 5. API calls beyond this limit are placed in a queue and are processed as ongoing requests complete. This approach ensures stable performance while efficiently handling multiple API calls.

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

Yes. This PR contains major architectural changes in the Prompt Studio, specifically in how the prompt run APIs are handled.

Database Migrations

NA

Env Config

NA

Relevant Docs

NA

Related Issues or PRs

NA

Dependencies Versions

NA

Notes on Testing

NA

Screenshots

image

Checklist

I have read and understood the Contribution Guidelines.

tahierhussain avatar Sep 27 '24 01:09 tahierhussain

@tahierhussain One quick question here, will this have impact in the PLG features where we make similar calls. We don't make runs in public share, but I am bit concerned about SPS.

@harini-venkataraman Yes. We don't make run calls in public share. SPS should work fine with minimal changes in the FE. I will be picking it up after we're done with the architectural changes in the FE.

tahierhussain avatar Oct 01 '24 01:10 tahierhussain

filepath function $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_logs}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_client\_init}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_run\_container}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{9}}$$ $$\textcolor{#23d18b}{\tt{9}}$$

github-actions[bot] avatar Oct 01 '24 04:10 github-actions[bot]