unstract icon indicating copy to clipboard operation
unstract copied to clipboard

fix/github-workflow-changes

Open kirtimanmishrazipstack opened this issue 1 year ago • 2 comments

What

  • Fixing pdm lock automation uncommited changes
  • Adding paths on automation

Why

  • When automation runs, if there is any uncommited changes, it fails
  • Workflow should run when pyproject.toml changes

How

On automation did the following:

  • Git stash (It will stash uncommited changes)
  • Generate lock file
  • Pull remote branch
  • Git stash pop.

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • N/A

Database Migrations

  • N/A

Env Config

  • N/A

Relevant Docs

Related Issues or PRs

Dependencies Versions

Notes on Testing

  • Chages pyproject.toml in backend, prompt, platform

  • Generated pdm.lock for backend, but didn't pushed.

  • Generated and pushed pdm.lock for platform

  • Workflow run successfully for all 3 services.

  • Since backend had unstaged changes, it didn't affect.

  • pdm lock was already pushed for platform, but automation generated new pdm lock changes

  • pdm lock generated for prompt.

Screenshots

Checklist

I have read and understood the Contribution Guidelines.

kirtimanmishrazipstack avatar Aug 13 '24 05:08 kirtimanmishrazipstack

@kirtimanmishrazipstack Why there are 54 commits in this branch? Please make sure to branch out from latest branch from next time.

@Deepak-Kesavan that's because to test, I manually changed pyproject.toml files. Then workflow will produce more commits on each job if the pdm lock has to be added. I also need to reverse the changes after testing it.

Since this cycle of repeated tests happened, more commits come. But this is not a concern

kirtimanmishrazipstack avatar Aug 19 '24 05:08 kirtimanmishrazipstack

filepath function $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_logs}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_client\_init}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_run\_container}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{9}}$$ $$\textcolor{#23d18b}{\tt{9}}$$

github-actions[bot] avatar Aug 21 '24 00:08 github-actions[bot]