unstract icon indicating copy to clipboard operation
unstract copied to clipboard

FEAT: Unified Notifications

Open jagadeeswaran-zipstack opened this issue 1 year ago • 5 comments

What

Unified Notifications consists of the following changes:

  1. Merging both log and notification messages to display them in the bottom logs component.
  2. Persisting both log and notification messages in Redis with a TTL of 1 hour.
  3. Making the logs component resizable, allowing users to drag and resize the component.
  4. Improving the styling of the logs component.

Why

The unified notification changes were implemented to enhance UX. Users can now see log and notification messages in one place, and these messages are persisted for 1 hour.

How

  1. Used Redis to store log and notification messages.
  2. Improved the styling of the components by using Antd components and additional custom styling.

Can this PR break any existing features. If yes please list of possible items. If no please exaplin why. (PS: Admins do not merge the PR without this section filled)

Yes, this PR can break existing features. The code changes have been made in quite a few existing modules, increasing the chances of regression.

Database Migrations

NA

Env Config

LOGS_EXPIRATION_TIME_IN_SECOND - This env variable stores the TTL in seconds. The default value is 3600 (1 hour).

Relevant Docs

NA

Related Issues or PRs

NA

Dependencies Versions

NA

Notes on Testing

NA

Screenshots

image image image

Checklist

I have read and understood the Contribution Guidelines.

jagadeeswaran-zipstack avatar Apr 25 '24 09:04 jagadeeswaran-zipstack

Few clarifications are required! Will the persisted logs visible to the user once he signs out and comes back in?

@jagadeeswaran-zipstack https://github.com/Zipstack/unstract/pull/290/files#r1624236148

johnyrahul avatar Jun 03 '24 12:06 johnyrahul

Few clarifications are required! Will the persisted logs visible to the user once he signs out and comes back in?

@johnyrahul Yes. I believe it should be visible.

nehabagdia avatar Jun 03 '24 13:06 nehabagdia

filepath function $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_logs}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_client\_init}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_run\_container}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{9}}$$ $$\textcolor{#23d18b}{\tt{9}}$$

github-actions[bot] avatar Aug 16 '24 10:08 github-actions[bot]

#1089 was already merged and hence closing this redundant PR. Please reopen if required - @jagadeeswaran-zipstack @tahierhussain