unstract icon indicating copy to clipboard operation
unstract copied to clipboard

fix reverse proxy mapping and traefik disabled

Open Fra5792 opened this issue 3 months ago • 4 comments

What

An issue was causing reverse-proxy a result of bad gateway

Why

Traefik and port mapping issue

I have read and understood the Contribution Guidelines.

Fra5792 avatar Sep 16 '25 10:09 Fra5792

Summary by CodeRabbit

  • Chores
    • Updated frontend service to route traffic to container port 80 while keeping external access on port 3000; added load balancer label to target port 80.
    • Disabled external routing for the internal createbuckets service in the development essentials configuration to prevent exposure.

Walkthrough

Updated Docker Compose configs: added a Traefik-disabling label for the createbuckets service in the dev essentials file, and changed the frontend service to expose container port 80 (not 3000) with a corresponding Traefik load balancer port label in the main compose file.

Changes

Cohort / File(s) Summary
Dev essentials Traefik config
docker/docker-compose-dev-essentials.yaml
Added labels with traefik.enable=false to the createbuckets service to disable Traefik routing.
Frontend exposure and Traefik label
docker/docker-compose.yaml
Changed frontend ports from 3000:3000 to 3000:80; added label traefik.http.services.frontend.loadbalancer.server.port=80.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description provides brief "What" and "Why" entries identifying a reverse-proxy bad gateway and attributing it to Traefik and port mapping, but it omits many required sections from the repository template such as "How", "Can this PR break any existing features", "Database Migrations", "Env Config", "Notes on Testing", and related items. The missing "Can this PR break any existing features" section is explicitly required by the template and prevents admins from merging. Because multiple mandatory fields are incomplete, the description is insufficient for review in its current state. Please update the PR description to follow the repository template: fill the "How" section with a concise summary of the file changes and why they fix the issue, explicitly state whether this PR can break existing features and list any affected areas, declare any database migrations or environment variable changes (or "none"), and add "Notes on Testing" showing steps to reproduce the bad gateway and the verification steps/logs you used; also include Related Issues/PRs and dependency/version notes so reviewers have full context before merging.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly references the two main changes in the changeset — fixing reverse-proxy mapping and disabling Traefik — which correspond to the frontend port remapping and the addition of a traefik.enable=false label; it is concise and relevant to the changes. It is slightly informal and could be more specific about which service had Traefik disabled (createbuckets). Overall the title summarizes the primary intent well enough for a quick scan by reviewers.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

[!TIP]

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Sep 16 '25 11:09 coderabbitai[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: ritwik-g
:x: Francesco Marchi


Francesco Marchi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 16 '25 11:09 CLAassistant

@Fra5792 the changes as such looks okay. Do you have any associated issues with this? Also can you add some screenshots of before and after of these changes?

Also please accept the CLA.

ritwik-g avatar Sep 17 '25 09:09 ritwik-g