ZipArchive icon indicating copy to clipboard operation
ZipArchive copied to clipboard

Support for splitting archive

Open webjib opened this issue 8 years ago • 7 comments

As minizip is supporting splitting zip archive, I've added a way to create archive with user-defined disk size. A disk size of 0 means we're using old open function. I've also added a size check to avoid creating parts of less than 1 KB (useful ?).

webjib avatar Nov 21 '17 17:11 webjib

Nice feature. But we can't change the signatures of createZipFileAtPath::: and open like that: we need to keep a compatibility layer, which I can easily write eventually.

Coeur avatar Nov 22 '17 00:11 Coeur

You're completely right, I should have kept previous signatures. I've made a new commit to restore them.

webjib avatar Nov 22 '17 06:11 webjib

I'll take a look at this after the holidays. Just want to let you know you were not forgotten. Thanks for the PR.

jhudsonWA avatar Dec 16 '17 17:12 jhudsonWA

Working on updating the included upstream minizip library to version 2, then I'll visit this one some more.

jhudsonWA avatar Feb 16 '18 00:02 jhudsonWA

Nice feature. But we can't change the signatures of createZipFileAtPath::: and open like that: we need to keep a compatibility layer, which I can easily write eventually.

你好,请问为什么不能暴露这个方法呢?是有其他的影响吗?如果要使用split的话,需要如何使用呢?直接在zip.c文件中修改ziinit.disk_size值吗?谢谢!


[edit: Google Translate]

Why can't you expose this method? Is there any other impact? If you want to use split, how do you use it? Modify the ziinit.disk_size value directly in the zip.c file?

zhouJinYing avatar Dec 07 '18 09:12 zhouJinYing

Wondering if you have any plan on merging this one...

Patr0ck avatar Jul 19 '19 16:07 Patr0ck

Thanks for the PR. If you can add some testcases we will merge in v3.0

willson-chen avatar Apr 28 '20 06:04 willson-chen