scilla
scilla copied to clipboard
Remove gas charges related to source file and input JSONs
These charges, to make it uniform with compiled Scilla, will be charged at the blockchain layer, so we must remove it here from Scilla.
https://github.com/Zilliqa/Zilliqa/issues/2678
Something doesn't look right.
I would expect all init output files to have a different gas_remaining with this PR. 31 files of the form
init_*.json
are changed in this PR, but we appear to have 87 of them in our testsuite:cnn@tautology:~/Projects/scilla$ ls -la tests/runner/*/init_*.json | wc -l 87
You are looking for init_*.json
, that would include init JSONs and init state JSONs too. Gas remaining is part of only the output JSONs.
Something doesn't look right. I would expect all init output files to have a different gas_remaining with this PR. 31 files of the form
init_*.json
are changed in this PR, but we appear to have 87 of them in our testsuite:cnn@tautology:~/Projects/scilla$ ls -la tests/runner/*/init_*.json | wc -l 87
You are looking for
init_*.json
, that would include init JSONs and init state JSONs too. Gas remaining is part of only the output JSONs.
I'm clearly not on top of my game. :-(
It looks fine, then.
@vaivaswatha : Status on this?
@vaivaswatha : Status on this?
I can't merge this till https://github.com/Zilliqa/Zilliqa/issues/2678 is done.