kaya icon indicating copy to clipboard operation
kaya copied to clipboard

Improve test coverage of kayaRPC

Open edison0xyz opened this issue 7 years ago • 1 comments

More testing vectors have to be introduced.

Test coverage for the CreateTransaction has been limited so far. Help needed to have more test cases to ensure correctness of CreateTransaction with smart contract. Payments testing has already been done under tests/transaction.test.js, but more vectors are welcome.

Currently only 50.87% of the lines have been covered under test case. Will be good if we can have 80% coverage since smart contract transaction is a significant portion of the code.

------------------------|----------|----------|----------|----------|-------------------|
File                    |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
------------------------|----------|----------|----------|----------|-------------------|
All files               |    50.77 |    43.59 |       56 |    50.87 |                   |
 kaya                   |    52.59 |    48.36 |    53.33 |    52.77 |                   |
  app.js                |    70.07 |    64.71 |    83.33 |    69.85 |... 14,215,220,221 |
  config.js             |      100 |      100 |      100 |      100 |                   |
  jest.config.js        |        0 |      100 |      100 |        0 |             18,38 |
  logic.js              |    49.76 |    44.05 |    64.71 |       50 |... 99,400,401,404 |
  server.js             |        0 |        0 |        0 |        0 |... 41,42,43,44,46 |
  utilities.js          |     5.56 |      100 |        0 |     5.56 |... 49,50,54,55,58 |
 kaya/components        |    83.33 |      100 |       50 |    83.33 |                   |
  blockchain.js         |    83.33 |      100 |       50 |    83.33 |                23 |
 kaya/components/scilla |    15.38 |        0 |        0 |    15.38 |                   |
  scilla.js             |    15.38 |        0 |        0 |    15.38 |... 08,209,212,214 |
 kaya/components/wallet |    74.49 |    60.47 |    84.62 |    74.49 |                   |
  wallet.js             |    74.49 |    60.47 |    84.62 |    74.49 |... 66,191,194,204 |
------------------------|----------|----------|----------|----------|-------------------|
Test Suites: 2 passed, 2 total
Tests:       19 passed, 19 total
Snapshots:   0 total
Time:        5.116s
Ran all test suites.

edison0xyz avatar Sep 27 '18 05:09 edison0xyz

This issue has been funded using FundRequest. A developer can claim the reward by submitting a pull request referencing this issue. (How to Close Issues via Pull Requests?) e.g. fixes #43

  • For more help on how to claim on issue, please visit our help section.
  • Looking for more? Feel free to browse through all funded requests.

fundrequestbot avatar Oct 20 '18 09:10 fundrequestbot