Gabor Varadi

There is no need to use JSONArray in Utils.loadProfiles()

11

You can replace the JSONArray with `TypeToken` and use GSON to parse the `List` directly. ``` java public class Utils { @NonNull public static List loadProfiles(Context context) { BufferedReader reader...

Fix many problematic API naming conventions in the Java library code

2

Fixes https://github.com/Digidemic/UnitOf/issues/3 Although I did not update the distribution included with the example.

https://github.com/HassanUsman/ToDo/blob/master/ToDo/app/src/main/java/com/example/hassanusman/getdisciplined/utils/AppUtils.kt#L23

After process death, the "category fragment" is re-loaded even though bottom nav shows otherwise

2

 Actual fix: ``` if(savedInstanceState == null) { loadFragment(new CategoryFragment()); } ```

After process death, the quiz says "please check your internet connection" and throws you back

3

 The good news is that I found no crashes in this regard :yum:

Firestore warning about java.util.Date

3

``` 02-01 23:38:46.290 5821-5821/com.app.horizon W/Firestore: (0.6.6-dev) [Firestore]: The behavior for java.util.Date objects stored in Firestore is going to change AND YOUR APP MAY BREAK. To hide this warning and ensure...

Consider integration with Paging library once it is stable

22

See https://medium.com/@Zhuinden/live-paged-lists-architecture-components-and-room-or-realm-268c9299a661 and https://github.com/Zhuinden/realm-helpers/blob/4b83911b20304355e95870e51a1743bc141a36fd/realm-pagination-example/src/main/java/com/zhuinden/realmpaginationexample/data/dao/TaskDao.java#L25-L28 ------------ Although I'm sure the API can be nicer (not having to explicitly open/close, and while keep the notification could be moved to a background handler...

Underlying native libraries pose potential security risk as per security analysis

2

 I'll have to remove the library from the project in order to fix this for now.

Similarly to older issues that have since been either closed or fixed such as https://github.com/android/architecture-samples/issues/370 and https://github.com/android/architecture-samples/issues/123 and https://github.com/android/architecture-samples/issues/731 and https://github.com/android/architecture-samples/issues/663 This bug seems to have been long-standing, but with...

https://github.com/googlesamples/android-architecture-components/blob/99aeb346caef2c545c98df953dfdeb3b50bb013d/BasicRxJavaSample/app/src/main/java/com/example/android/observability/ui/UserViewModel.java#L47 This can't be right.