Zhi Yuan

Results 17 issues of Zhi Yuan

``` addPerson(ReadOnlyPerson) adds the ReadOnlyPerson to the address book and updates the filtered list to display all persons. This is unnecessary coupling as the Model should only concern itself with...

p.High
a-CodeQuality
d.FirstTimers
chore

`PersonNotFoundException` can only be initialized using the empty constructor and does not have an error message. Also, `DuplicatePersonException` can only be initialized with a default error message. The lack of...

c.Enhancement
a-CodeQuality
chore

For example, in the User Guide, under `Quick Start` (Section 1) point 5: ``` 5. Some example commands you can try: * **`list`** : lists all contacts * **`add`**` John...

p.Low
a-Docs
d.FirstTimers
chore

Commands that do not require any parameters such as `HelpCommand` and `ClearCommand` will be parsed correctly even though the user input contains additional parameters e.g `help 3`, `clear lalala`. As...

p.Low
c.Enhancement
d.Committers

`SelectCommand` selects a card and scrolls to the card. `SelectCommandSystemTest` does not verify that the card is visible. Let's update `SelectCommandSystemTest` to verify that the person card is in the...

d.Committers

... so that users can set their preferred storage location. This will be implemented by allowing commands to have access to the `Storage` component.

p.Low
c.UserStory
d.Contributors
a-Architecture

Prerequisite #547 To solve this issue, simply update `MESSAGE_SUCCESS` (see the regex of `EditCommand#MESSAGE_EDIT_PERSON_SUCCESS`), and return `new CommandResult(String.format(MESSAGE_EDIT_PERSON_SUCCESS, undoneCommand))`

c.Enhancement
d.FirstTimers