Zhi Yuan
Zhi Yuan
Did some testing and realised there's some slight differences between some of the answers above. This answer actually checks out the PR branch > steps: > - id: 'get-branch' >...
Hey @rady-msaad, nope, I am considering retrying using the most basic .devcontainer file possible and see if it works (if it doesn't then I'm out of ideas on how to...
@yamgent I will put this as an first timer issue, since the person can refer to my existing code and work on it :P Whoever decides to work on this,...
Not too sure, what do you suggest? :P How about `Logic#getViewModel()`? The header comments can be `Returns an unmodifiable {@code ObservableList} for the UI to bind itself to.` It seems...
> I think we did discuss about it before regarding how it feels rather weird to have a UI component being stored inside the Logic class, but we sort of...
We can't really make all commands undoable, such as `HelpCommand` :P `HistoryCommand` is kinda weird to be undoable as well though.
> resetting the view to show all persons after every undo and redo? I think it's just cos other commands that update the backing list of `PersonListPanel` will reset the...
> In some cases the user may no longer be interested in the previous filtered list. I guess it's a bit hard to argue for the use case because we...
@damithc do we have to write system tests for: 1. `ExitCommand` (I think we definitely can't write for this :P) 1. `HelpCommand` 1. `HistoryCommand` 1. `ListCommand` 1. `RedoCommand` 1. `UndoCommand`...
Noted. I will put the emphasis on porting the existing tests from `guitests` to `systemtests`, before implementing for the commands listed above. ^^