PGPortfolio icon indicating copy to clipboard operation
PGPortfolio copied to clipboard

Three questions

Open sergei-bondarenko opened this issue 4 years ago • 2 comments

  1. Why did you publicly share the algorithm and not use yourself or sell it if the results are so good and consistent?

  2. In a readme you wrote "Original versioning history, and internal discussions, including some in-code comments, are removed in this open-sourced edition. These contains our unimplemented ideas, some of which will very likely become the foundations of our future publications". In other issues you also refused to give any even smallest hints about these ideas. Why are you behaving like that?

  3. Did you run test only once just to measure results? Or you used it multiple times? I know that you used CV for hyperparameters tuning, but there is also can be a data leakage if you run your model on a test set and tweak it a little bit if the results are bad. When you repeat this several times then the test set can also become "dirty".

Hope you will answer. Thank you!

sergei-bondarenko avatar Dec 16 '19 08:12 sergei-bondarenko

I reimplemented their work, the model can perfectly fit the training data, but can NOT generalize to unseen data robustly. By "not robust" I mean,

  1. different seed yields very different results
  2. even though for one model it can outperform in some chuck of unseen data, but on other data it behaves very badly

either I missed something from their paper and implementation or I have to conclude that this work is NOT practical at all.

liuyangdh avatar Aug 13 '20 13:08 liuyangdh

@liuyangdh Do you have your reimplementation available? Am curious to see what you did. Thx!

tr8dr avatar Jan 12 '21 13:01 tr8dr