mod-individual-progression icon indicating copy to clipboard operation
mod-individual-progression copied to clipboard

Warnings on build

Open XSNomad opened this issue 2 years ago • 2 comments

[ 22%] Building CXX object src/server/scripts/CMakeFiles/scripts.dir/Commands/cs_bag.cpp.o
/home/ubuntu/azerothcore/modules/mod-individual-progression/src/IndividualProgression.cpp:74:62: warning: '&&' within '||' [-Wlogical-op-parentheses]
        hasPassedProgression(player, PROGRESSION_TBC_TIER_5) && (item->RequiredLevel <=70))
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/ubuntu/azerothcore/modules/mod-individual-progression/src/IndividualProgression.cpp:74:62: note: place parentheses around the '&&' expression to                                                                                                                                                silence this warning
        hasPassedProgression(player, PROGRESSION_TBC_TIER_5) && (item->RequiredLevel <=70))
                                                             ^
        (                                                                                 )
/home/ubuntu/azerothcore/modules/mod-individual-progression/src/IndividualProgression.cpp:85:62: warning: '&&' within '||' [-Wlogical-op-parentheses]
        hasPassedProgression(player, PROGRESSION_TBC_TIER_5) && (item->RequiredLevel <=70))
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/ubuntu/azerothcore/modules/mod-individual-progression/src/IndividualProgression.cpp:85:62: note: place parentheses around the '&&' expression to                                                                                                                                                silence this warning
        hasPassedProgression(player, PROGRESSION_TBC_TIER_5) && (item->RequiredLevel <=70))
                                                             ^
        (                                                                                 )
/home/ubuntu/azerothcore/modules/mod-individual-progression/src/IndividualProgression.cpp:140:10: warning: unused variable 'bp1Healing' [-Wunused-varia                                                                                                                                               ble]
    auto bp1Healing = static_cast<int32>(computedHealingAdjustment);
         ^
/home/ubuntu/azerothcore/modules/mod-individual-progression/src/IndividualProgression.cpp:138:11: warning: unused variable 'bp0' [-Wunused-variable]
    int32 bp0 = 0; // This would be the damage taken adjustment value, but we are already adjusting health
          ^

XSNomad avatar Jan 24 '23 05:01 XSNomad

me too,always stopped due to "fatal error"

houbing2006 avatar Jun 13 '23 07:06 houbing2006

This is very old. Is this really still an issue today?

Grimfeather avatar Aug 14 '24 05:08 Grimfeather