Nadeshiko Manju
Nadeshiko Manju
I have update the PR, PTAL @kailun-qin @gnoack @l0kod
> I think the bigger chance for mistakes is in the implementation itself. - Are you planning to add that in the same PR, or will that come separately? I...
> Before working on this we have to revisit whether we really need to split the pkgs, and what are potential drawbacks Totally agree, but I think the stage1(refactoring the...
> * I agree each command should have a `CommandOption` struct, regardless small or large. We should put them in a separate pkg (e.g., `api/types.go`, or `pkg/api/types.go`). > * Then...
> Welcome back @Zheaoli wave, Thanks(lol > I like the idea of having `pkg/apis/` that contains the API resource definitions. We can split api files based on corresponding feature type:...
What are other people's thoughts? @containerd/nerdctl-reviewers @containerd/nerdctl-committers
```text WARN[0000] unable to determine buildctl version: exec: "buildctl": executable file not found in $PATH Client: Version: v1.5.0 OS/Arch: linux/amd64 Git commit: b33a58f288bc42351404a016e694190b897cd252 buildctl: Version: Server: containerd: Version: 1.7.1+azure-1 GitCommit:...
我准备先把 Parse 还有 goroutine 之间数据传输的瓶颈解决了再来处理下并行 writer
这里我考虑的一点是将文件名作为 aof offset 的存放位置好像不太合适，我们这里需要一个 metadata 的抽象 @suxb201 WYDT
这里我考虑的是将 buffer 管理这一块抽象出来，做一个 BufferManager，支持两种模式，一种是 Memory Buffer，一种是 File Buffer