Realtime_Multi-Person_Pose_Estimation icon indicating copy to clipboard operation
Realtime_Multi-Person_Pose_Estimation copied to clipboard

Difference in paper and code

Open anatolix opened this issue 6 years ago • 4 comments

Paper says: screen shot 2017-11-14 at 00 05 40

Code is following https://github.com/CMU-Perceptual-Computing-Lab/caffe_train/blob/master/src/caffe/cpm_data_transformer.cpp screen shot 2017-11-14 at 01 33 49

I.e. not max, but min(sum(...),1.0)

anatolix avatar Nov 13 '17 22:11 anatolix

Yes, this is actually a bug. It should be min(max(...), 1.0). Thank you for pointing out.

ZheC avatar Nov 14 '17 23:11 ZheC

@ZheC thank you.

p.s. Speaking about a bugs - probably you have another one, some PAF could became NaN, I've pointed to the line of code here https://github.com/ZheC/Realtime_Multi-Person_Pose_Estimation/issues/102

please check it too.

It should be min(max(...), 1.0)

actually max(...) will be enough since original function can't be more than 1.0

anatolix avatar Nov 14 '17 23:11 anatolix

Another difference about PAF. paper says: screen-2017-11-16-20-00-06 the code is: screen-2017-11-16-20-03-05

If don't update the value of cnt when cnt = 0. The value of cnt always will be 0. And the value of paf will be the last part value, not the average of the affinity fields of all people in the image.

So I think ther is no need to make a special judgment when cnt = 0.

last-one avatar Nov 16 '17 12:11 last-one

Paper says: screen shot 2017-11-14 at 00 05 40

Code is following https://github.com/CMU-Perceptual-Computing-Lab/caffe_train/blob/master/src/caffe/cpm_data_transformer.cpp screen shot 2017-11-14 at 01 33 49

I.e. not max, but min(sum(...),1.0)

I can not find which line, the picture you show did not contain max op.

Hanhanhan11 avatar Sep 15 '18 02:09 Hanhanhan11