ZhangHuiGui

@zanmato1984 Thank you very much for your suggestion, the code looks clearer!

> My one last suggestion :) Thanks!

@pitrou PTAL! The new commit include two things: 1. Move these codes(key_hash/key_map/light_array) to internal! Besides, seems it's unnecessary to use internal namespace for them. The purpose we want is just...

I think it's a problem and we should fix it. Below codes could prove this problem: ```c // Normal expression TEST(DecimalTest, Divide) { auto expr = arrow::compute::call("divide", {arrow::compute::field_ref("f1"), arrow::compute::field_ref("f2")}); auto...

> I'm not sure what is the important part in the codes. Could you explain it? The test codes are the decimal divide operation in compute expression and gandiva expression....

> I thought that you refer Redshift's rules not our compute module's one. Actually our compute module's decimal rules is the same with Redshift's rules. Compute module implement the rules...

@kou Added the compatibility in the pr. PTAL?

cc @kou PTAL this issue?

> Can you provide a buildable C++ code that reproduces this problem? Of course. ```c #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include...