ZeroK-RTS
Should armor (Crabe etc) protect vs fall damage and collisions?
~~Apparently engine doesn't apply armor to ground collisions (i.e. fall damage) and object collisions:~~ ~~https://github.com/beyond-all-reason/spring/blob/7363dbc54b55d309539b92c60245f88afd1f4e4a/rts/Sim/Units/Unit.cpp#L1298-L1306~~
~~It would probably be good for consistency if it applied. I think engine should just do this natively (since the distinction is very opaque, I had no idea until now) so maybe that will happen and nothing will need to be done gameside.~~
Edit: looks like we ignore engine input for fall and unit collision and calculate damage from scratch, but the gadgeted value still ignores armor (so e.g. if a modder sets armorMult = 0 for an invulnerable unit it can still get damaged). Also, collisions with features are separate from collisions with units and still use the native value.
It would be a possibly significant balance change to Crabe though since falling from a spire is a common scenario.
From a gameplay perspective, I think it would be better if it was the case. It just makes armour a bit more consistent and is what makes logical sense. The balance issues can be mostly fixed by Armoured having higher mass based on the amount of armor they have, so crab still takes around the fall damage when falling from a spire
Changing mass when armored might also positively affect its interaction with gravity beams, which are currently an absurd hard counter to crab.
However, from my experience gravity interactions make crab try to move to its previous position even on "hold position", making it remove its armor on its own. Unless that is fixed, changes to collision damage while armored wouldn't have any significant effect, since in most cases it will have left its armored state already before impact.
It should also be not allowed to change armour without being able to move (ie because it is flying).
