Raylib-CSharp-Vinculum icon indicating copy to clipboard operation
Raylib-CSharp-Vinculum copied to clipboard

Rectangle has two of each property

Open Kinkyboo opened this issue 1 year ago • 2 comments

Both uppercase and lowercase property names are public. The lowercase name should be private or protected.

Checking the repository I can only find the partial implementation of Rectangle that uses the lowercase names but does not define them, where is the other half of the rectangle class?

https://github.com/ZeroElectric/Raylib-CSharp-Vinculum/blob/5.xx-dev/Source/Raylib-CSharp-Vinculum/_wrappersOther.cs#L47

The latest nuget package presents this:

public struct Rectangle
{
    public float x;

    public float y;

    public float width;

    public float height;

    public float X
    {
        get
        {
            return x;
        }
        set
        {
            x = value;
        }
    }

    public float Y
    {
        get
        {
            return y;
        }
        set
        {
            y = value;
        }
    }

    public float Width
    {
        get
        {
            return width;
        }
        set
        {
            width = value;
        }
    }

    public float Height
    {
        get
        {
            return height;
        }
        set
        {
            height = value;
        }
    }

    public Rectangle(float x, float y, float width, float height)
    {
        this.x = x;
        this.y = y;
        this.width = width;
        this.height = height;
    }
}

Kinkyboo avatar Jan 20 '24 16:01 Kinkyboo