ps4_nid_resolver_ida icon indicating copy to clipboard operation
ps4_nid_resolver_ida copied to clipboard

Published 20 hours ago • verified publisher icon Zer0xFF

Fix crash caused by incorrect JSON format.

Open DummyCatz opened this issue 5 years ago • 3 comments

The json files in ps4libdoc may contains BOM header, which can not be handled by the json library correctly and can cause crash. This fix removes any bytes before '{' and wraps the json parsing code with try {} catch{} block.

DummyCatz avatar Feb 22 '20 00:02 DummyCatz

Hi there, Thanks for the PR, I dont have my envioremnt setup to build this now, to test, but this looks good to me.

I wonder, if its better to ask upstream https://github.com/open-source-parsers/jsoncpp to fix this (if its not already fixed, the json parser is 2ish years out of date from upstream)

Zer0xFF avatar Feb 28 '20 09:02 Zer0xFF

Jsonpp may not fix this issuse because the BOM characters are illegal in JSON according to the RFC 8259, Section 8.1. And here is the issuse in their repo: https://github.com/open-source-parsers/jsoncpp/issues/1141

DummyCatz avatar Mar 02 '20 02:03 DummyCatz

@DummyCatz Thank you for the fix. Does it work on IDA PRO 7.2 as well as 7.0 ? What about 7.5 ? @Zer0xFF May you share a compiled version in Releases please ?

CelesteBlue-dev avatar Jun 21 '22 14:06 CelesteBlue-dev