curv icon indicating copy to clipboard operation
curv copied to clipboard

Incorrect documentation for `check_point_order_equals_group_order`

Open tjade273 opened this issue 2 years ago • 2 comments

In the documentation for check_point_order_equals_group_order, https://github.com/ZenGo-X/curv/blob/44537a746292be65961e9c38191319c17a3d2977/src/elliptic/curves/traits.rs#L185

should presumably read

/// P ≠ 0 ∧ qP = 0

The implementation appears to be correct, so just a simple doc fix should suffice.

tjade273 avatar Jul 20 '22 02:07 tjade273

In addition, https://github.com/ZenGo-X/curv/blob/44537a746292be65961e9c38191319c17a3d2977/src/elliptic/curves/bls12_381/g2.rs#L249

should say G2 instead of G1

tjade273 avatar Jul 25 '22 16:07 tjade273

Thanks @tjade273 , feel free to open a PR :)

leontiadZen avatar Mar 29 '23 11:03 leontiadZen