class icon indicating copy to clipboard operation
class copied to clipboard

Improve build process

Open omershlo opened this issue 5 years ago • 4 comments

Currently the build.rs file will re-install pari library each time we cargo build. This is taking very long time and unnecessary if pari is already installed. Find a way to change build.rs to check if pari is already installed and if it does - skip installation.

omershlo avatar Jul 20 '19 21:07 omershlo

The build process could use some overhauling in general. For Windows/macOS the library should just be statically linked and not leave any artifacts on the system.

knarz avatar Jul 22 '19 18:07 knarz

I agree. can you help ?

omershlo avatar Jul 22 '19 19:07 omershlo

Suggestion: PARI is a well maintained library, and has extensive installation documentation ftp://pari.math.u-bordeaux.fr/pub/pari/manuals/2.7.6/INSTALL.pdf as well as packages in at least some Linux distributions: https://packages.ubuntu.com/bionic/libpari-dev

Why not add interactions for installation, then remove the entire make process from build.rs?

I was able to compile and pass all tests without rebuilding the local library (which of course takes a lot less time)

Alternatively, add it as a git submodule, with installation instructions

amanusk avatar Jul 24 '19 06:07 amanusk

I saw this method in other libraries. One motivation is that in my method you don't need to update version and make adjustments for each new Pari versions. Another possible advantage is that we can make changes to Pari

omershlo avatar Jul 24 '19 06:07 omershlo