Tingle icon indicating copy to clipboard operation
Tingle copied to clipboard

Published 20 hours ago • verified publisher icon Zelda-Universe

Hide ads for authenticated users

Open GoldenChaos opened this issue 6 years ago • 2 comments

This was pull requested, but upon testing I found that it actually currently completely disables ads. Oops 😛

GoldenChaos avatar Jul 19 '18 12:07 GoldenChaos

Checked on staging. image

Both ad elements exist. The proper ones are hidden and shown, just not populated. I see we have the google ad tracking file in source control. I saw the ads on production, but I guess this is the old code since you reverted #159 in production.

Pysis868 avatar Jul 19 '18 14:07 Pysis868

This is not true @Pysis868 - the ads are populated but not shown, I've just finished testing. Something is hiding the ad related to your changes. The ad shows up properly when your changes are reverted.

GoldenChaos avatar Jul 22 '18 15:07 GoldenChaos