Peter Hill

Results 158 issues of Peter Hill

It's been almost six years since the last release, and there have been several issues fixed since then. Are there plans for a new release? If the issue is maintainer...

We should build BOUT++ separately and cache the built artefacts. This would reduce the build time on CI significantly.

I had missed that there was a separate target for the library, so the warnings were only being enabled on the executable. Luckily I'd already fixed most of the warnings,...

Includes #368. ~e94eb10727065ea855cbdf388a8781b3bdfc0808 is the commit merging `sheath_boundary` into `sheath_boundary_simple`.~ ~Current task is to see about merging `sheath_boundary_insulating` in as well.~ Merges `sheath_boundary`, `sheath_boundary_simple`, and `sheath_boundary_insulating` into a single implementation...

`sheath_boundary_simple` is only designed for single species and is missing some factors that appear in the full expressions. Unfortunately, it seems that we don't know how many species we have...

- Adds a golden answer regression test with five different cases, plus a unit test which has some basic sense checking - Breaking change: make the "boundary_mode" input an enum,...

boundary conditions
tests
refactor

``` /home/peter/Codes/freegs/freegs/critical.py:149: DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array...

I've tried to keep individual checks or at least categories to a single a commit