clang-tidy-review icon indicating copy to clipboard operation
clang-tidy-review copied to clipboard

Published 20 hours ago • verified publisher icon ZedThree

Support clang-tidy-13

Open vadi2 opened this issue 3 years ago • 8 comments

It would great to have support for the latest version of clang-tidy :+1:

vadi2 avatar Feb 26 '21 13:02 vadi2

AFAICT clang-tidy-11 is already part of the focal universe: https://packages.ubuntu.com/focal-updates/clang-tidy-11

ghutchis avatar Apr 29 '21 18:04 ghutchis

Sure, but I mean 12

vadi2 avatar Apr 29 '21 19:04 vadi2

I know - but clang-tidy-12 isn't yet available for focal, so AFAIK, it's not just a quick Dockerfile update.

ghutchis avatar Apr 29 '21 19:04 ghutchis

I guess if LLVM 12 is available from a reputable PPA, that would work?

ZedThree avatar Apr 30 '21 19:04 ZedThree

I'm not a Dockerfile expert.. Worth a try: https://packages.ubuntu.com/hirsute/clang-tidy-12

ghutchis avatar Apr 30 '21 19:04 ghutchis

clang-tidy-13 is out now and adds some great checks such as https://clang.llvm.org/extra/clang-tidy/checks/readability-function-cognitive-complexity.html, would be great to make use of it in PRs - sometimes people contribute functions way too big.

vadi2 avatar Jan 15 '22 10:01 vadi2

We should at least add clang-tidy-12 which is available for focal: https://packages.ubuntu.com/focal-updates/clang-tidy-12

umutoztunc avatar Jan 28 '22 10:01 umutoztunc

I've added clang-tidy-12. I think it's important that the base image is something fairly standard, otherwise it could be painful to support most people's workflows. This means that supporting the latest clang-tidy as it's released is probably a no-go I'm afraid.

If someone knows how to make the base image be an argument from the Action, then PRs are very much welcome :)

ZedThree avatar Jan 31 '22 14:01 ZedThree