paper-stepper
paper-stepper copied to clipboard
Zecat
Upgrading to Hybrid mode
Resolves #67
I've gone through some steps of upgrading elements to Hybrid mode so they work in Polymer 1 (>1.9) and 2.0
~~The element is now pretty functional but some styles don't get applied and I'm not sure why. Please help. 😧~~
It'd also be needed to move animations to standard Web Animations API instead of neon-animations as they got deprecated.
I also would suggest to do some more testing on it before publishing, I'm not good at testing 😖.
Hy, for your style problems you also have change var(--var1, --var-2) to var(--var1, var(--var2)), hope it helps!
Sorry for late response. Thanks for advice! But seems like you have already implemented hybrid mode so I think you can now close this PR.
@myfrom With the changes @thetaPC recommended and @Zecat said for the styles it solves the issue. Would heavily recommend trying to get your branch pushed for the hybrid mode as it is better then the current one imo. The style changes need to be done in the step-label-shared-styles.html.
Also add this
"iron-menu-behavior": "PolymerElements/iron-menu-behavior#^2.0.0"
in bower.json
It also complains without it.
Very excited to getting this version of the hybrid completed. The current one is still a prototype and lacks a few components.
Sorry for breaking my promise but I won't be able to push it today 😞 I'm going on a trip tomorrow morning and will try to push it as soon as I get stable internet tomorrow. Sorry once again
OK, so I merged all PRs to my code (Huge thanks for them!) but the vertical option doesn't seem to work I'm looking into it right now
Awesome! I did notice when using the browser's device emulator (Chrome and Firefox), not all the default phones would work.
@rjsteinert I will say that myfrom's version is way better than the original. I ended up using it for my internship. They were really pleased with it and we were using Polymer 2.
So a little update: I have checked a bit on my local machine and I found out that both mine and Zecat's hybrid version (Polymer-2 or hybrid-modular-prototype respectively) seems to work the same. However, there are huge code changes in Zecat's version (at least on diffs) as opposed to my approach with minimal changes. I think this could be safely merged to master now without breaking anything and having great compatibility with other PRs. Could you tell what do you think about it, @Zecat?
It's been many years since then. Have we considered closing out this PR due to inactivity?