zebra icon indicating copy to clipboard operation
zebra copied to clipboard

change(config): Allow square brackets in network config listen addr and external addr

Open arya2 opened this issue 2 months ago • 0 comments

Motivation

Closes #8476.

PR Author Checklist

Check before marking the PR as ready for review:

  • [x] Will the PR name make sense to users?
  • [x] Does the PR have a priority label?
  • [x] Have you added or updated tests?
  • [x] Is the documentation up to date?
For significant changes:
  • [x] Is there a summary in the CHANGELOG?
  • [x] Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

Try adding the default port to the config value and parsing that as a SocketAddr before trying to parse it as an IpAddr

Testing

Manually tested that the config accepts [::]

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • [ ] Does the PR scope match the ticket?
  • [ ] Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • [ ] Are all the PR blockers dealt with? PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

arya2 avatar May 03 '24 16:05 arya2