zebra icon indicating copy to clipboard operation
zebra copied to clipboard

main branch CI failed: push in Multi-OS Unit Tests

Open github-actions[bot] opened this issue 2 months ago • 10 comments

GitHub Actions workflow Multi-OS Unit Tests #1226 failed.

Event: push Branch: main Commit: 183249d2edf3d689b8f39c8bd7a2b5e6d4cb5e5a

Created by jayqi/failed-build-issue-action

github-actions[bot] avatar May 03 '24 14:05 github-actions[bot]

Port permissions issue on Windows: https://github.com/ZcashFoundation/zebra/actions/runs/8940029495/job/24557280477#step:12:4843

arya2 avatar May 03 '24 16:05 arya2

GitHub Actions workflow Multi-OS Unit Tests #1262 failed.

Event: push Branch: main Commit: 3e264c73a65079746d0c16ea4ee59ac0062f345e

Created by jayqi/failed-build-issue-action

github-actions[bot] avatar May 07 '24 20:05 github-actions[bot]

GitHub Actions workflow Multi-OS Unit Tests #1264 failed.

Event: push Branch: main Commit: 0040c2be87a6ddbeb3ca60558accca1171787757

Created by jayqi/failed-build-issue-action

github-actions[bot] avatar May 07 '24 21:05 github-actions[bot]

GitHub Actions workflow Multi-OS Unit Tests #1266 failed.

Event: push Branch: main Commit: 15e1096826532f8fbb9ebaa70fee0fd280fd29c0

Created by jayqi/failed-build-issue-action

github-actions[bot] avatar May 08 '24 15:05 github-actions[bot]

This issue relates to:

  • https://github.com/ZcashFoundation/zebra/issues/1765
  • https://github.com/ZcashFoundation/zebra/issues/1769

Seems like it needs some Rust code review from previous fixes

gustavovalverde avatar May 08 '24 17:05 gustavovalverde

The test failing seems to be non_blocking_logger: https://github.com/ZcashFoundation/zebra/actions/runs/9003850454/job/24735443640#step:12:9013

This test seems to be already unreliable for macos: https://github.com/ZcashFoundation/zebra/blob/main/zebrad/tests/acceptance.rs#L1705

We might want to disable it for windows as well.

oxarbitrage avatar May 08 '24 18:05 oxarbitrage

GitHub Actions workflow Multi-OS Unit Tests #1275 failed.

Event: push Branch: main Commit: a6569d4881d58b25f7f2f55a6b558144447bce4f

Created by jayqi/failed-build-issue-action

github-actions[bot] avatar May 10 '24 19:05 github-actions[bot]

GitHub Actions workflow Multi-OS Unit Tests #1275 failed.

Another port conflict: https://github.com/ZcashFoundation/zebra/actions/runs/9036496204/job/24833493391#step:12:4079

arya2 avatar May 13 '24 18:05 arya2

@gustavovalverde we should looking into why we're getting more port conflict issues in tests lately, e.g see #8525

mpguerra avatar May 14 '24 10:05 mpguerra

This has been (historically) a Windows tests issue. I can dig deeper into this, but maybe I should match with an Engineer to confirm if this is something that must be fix in Rust or in the Infrastructure.

gustavovalverde avatar May 14 '24 13:05 gustavovalverde

GitHub Actions workflow Multi-OS Unit Tests #1300 failed.

Event: push Branch: main Commit: 0f5450f5650102aea1fff43ec88c065ef1976e79

Created by jayqi/failed-build-issue-action

github-actions[bot] avatar May 15 '24 22:05 github-actions[bot]

@arya2 can you take a look and sync up with @gustavovalverde on this one?

mpguerra avatar May 16 '24 08:05 mpguerra

It's a Rust issue. It can't use OS-assigned ports on Windows in the same way it does for Linux/maxOS, so it's picking random numbers in a range of ports that could be available.

arya2 avatar May 16 '24 13:05 arya2

Let's disable this test for windows then and move on :)

mpguerra avatar May 16 '24 14:05 mpguerra