zebra icon indicating copy to clipboard operation
zebra copied to clipboard

add(consensus): Add `slow_start_{interval/shift}` fields to `testnet::Parameters`

Open arya2 opened this issue 2 months ago • 1 comments

Motivation

This PR adds fields to testnet::Parameters and is cleanup for #8475.

Part of #7119.

Depends-On: #8475.

PR Author Checklist

Check before marking the PR as ready for review:

  • [x] Will the PR name make sense to users?
  • [x] Does the PR have a priority label?
  • [x] Have you added or updated tests?
  • [x] Is the documentation up to date?
For significant changes:
  • [x] Is there a summary in the CHANGELOG?
  • [x] Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Adds slow_start_interval and slow_start_shift fields to testnet::Parameters
  • Moves SLOW_START_INTERVAL and SLOW_START_SHIFT constants to zebra-chain

Testing

The new_regtest() method should be tested by regtest_submit_blocks(), some of the rest should be covered by existing tests, there may be a minor gap in coverage considering a mistake was made in the previous PR.

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • [ ] Does the PR scope match the ticket?
  • [ ] Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • [ ] Are all the PR blockers dealt with? PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

arya2 avatar Apr 30 '24 23:04 arya2

@arya, this PR needs a manual conflict resolution.

upbqdn avatar May 02 '24 20:05 upbqdn