zebra icon indicating copy to clipboard operation
zebra copied to clipboard

Add protocol version information to fields on `NetworkParameters`

Open arya2 opened this issue 1 year ago • 2 comments

Motivation

We want to make these values configurable on Testnets:

See https://github.com/ZcashFoundation/zebra/pull/7924#discussion_r1385877140.

Outdated: These have already been added.

Possible Design

Check what values zcashd uses for Regtest and either:

  • Add them to these HashMaps for Testnet with Regtest parameters (this support custom testnets, only Regtest), or
  • Add them as fields in NetworkParameters and set the Regtest values in Network::new_regtest (#7839):

arya2 avatar Mar 20 '24 03:03 arya2

This isn't a priority right now

arya2 avatar Jul 08 '24 14:07 arya2

We still want to move INITIAL_MIN_NETWORK_PROTOCOL_VERSION to a field on testnet::Parameters.

arya2 avatar Aug 22 '24 23:08 arya2

This is mostly cleanup, but if we make this change and also allow for defining consensus branch ids in the config, we could participate in the following round of private Testnet testing without making any code changes.

arya2 avatar Aug 13 '25 04:08 arya2

not a priority right now

mpguerra avatar Oct 27 '25 15:10 mpguerra