zebra icon indicating copy to clipboard operation
zebra copied to clipboard

build(deps): Remove `arrayvec` and `itoa` from `skip-tree`

Open upbqdn opened this issue 1 year ago • 0 comments

Motivation

We recently updated inferno, which depends on num_format, which depends on arrayvec and itoa, and running

cargo deny --all-features check bans

started producing the following warnings:

   ┌─ .../zebra/deny.toml:89:5
   │
89 │     { name = "arrayvec", version = "=0.4.12" },
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no crate matched these criteria

warning[B010]: skip tree root was not found in the dependency graph
   ┌─ .../zebra/deny.toml:90:5
   │
90 │     { name = "itoa", version = "=0.4.8" },
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no crate matched these criteria

bans ok

Solution

The warning means we don't need to list the arrayvec and itoa dependencies in the skip-tree section, so this PR removes them.

Reviewer Checklist

  • [ ] Will the PR name make sense to users?
    • [ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • [ ] Are the PR labels correct?
  • [ ] Does the code do what the ticket and PR says?
  • [ ] How do you know it works? Does it have tests?

upbqdn avatar Oct 14 '22 16:10 upbqdn