zebra icon indicating copy to clipboard operation
zebra copied to clipboard

Run mining pool software in CI to test `zebrad` RPCs

Open mpguerra opened this issue 2 years ago • 1 comments

Motivation

We want to test our RPCs against the software that uses them, to make sure we got the names, parameters, and fields correct.

Proposed Solution

We can run the latest version of https://github.com/s-nomp/s-nomp , connect it to zebrad, and check for successes or failures in the logs.

This will be like the lightwalletd_integration test: https://github.com/ZcashFoundation/zebra/blob/75a679792bb787b95b4e9ce87aaefe205c48c97a/zebrad/tests/acceptance.rs#L1505

Out of Scope

We won't be mining blocks in CI, we can provide known-good blocks from the non-finalized chain.

mpguerra avatar Sep 29 '22 09:09 mpguerra

I don't think this needs to block development of the RPC calls. We can start development when we are ready to start work on this, and test against the mining pool software once we have it, first manually and then in CI once this issue is complete.

mpguerra avatar Sep 30 '22 09:09 mpguerra

We decided that this was out of scope at the engineering meeting today. We only need to do this if the manual tests in #6025 aren't enough.

teor2345 avatar Jan 24 '23 00:01 teor2345