zebra icon indicating copy to clipboard operation
zebra copied to clipboard

build(deps): bump chrono from 0.4.19 to 0.4.20

Open teor2345 opened this issue 1 year ago • 1 comments

Motivation

chrono has fixed rust security advisory: https://rustsec.org/advisories/RUSTSEC-2020-0159

It has also fixed some panic bugs.

Solution

  • Bump chrono to 0.4.20

Related build / security fixes:

  • Drop old time crate dependency from chrono

Related clippy fixes:

  • Fix clippy::assign_op_pattern
  • Update deprecated constant names

Review

Zebra isn't actually vulnerable to this security issue in our direct use of chrono, but tracing might be, so we should get this merged before the next release.

Reviewer Checklist

  • [ ] Existing tests pass

teor2345 avatar Aug 06 '22 03:08 teor2345

Codecov Report

Merging #4898 (5b021d9) into main (1d861b0) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4898      +/-   ##
==========================================
- Coverage   79.04%   79.04%   -0.01%     
==========================================
  Files         309      309              
  Lines       38781    38783       +2     
==========================================
+ Hits        30656    30657       +1     
- Misses       8125     8126       +1     

codecov[bot] avatar Aug 06 '22 04:08 codecov[bot]

We're seeing panics in Zebra, so this is now a high priority.

teor2345 avatar Aug 24 '22 00:08 teor2345

@mergifyio update

teor2345 avatar Aug 24 '22 00:08 teor2345

update

✅ Branch has been successfully updated

mergify[bot] avatar Aug 24 '22 00:08 mergify[bot]

@mergifyio update

teor2345 avatar Aug 25 '22 20:08 teor2345

update

✅ Branch has been successfully updated

mergify[bot] avatar Aug 25 '22 20:08 mergify[bot]

@mergifyio update

oxarbitrage avatar Aug 26 '22 14:08 oxarbitrage

update

✅ Branch has been successfully updated

mergify[bot] avatar Aug 26 '22 14:08 mergify[bot]

@mergifyio update

teor2345 avatar Aug 28 '22 12:08 teor2345

update

✅ Branch has been successfully updated

mergify[bot] avatar Aug 28 '22 12:08 mergify[bot]