zebra icon indicating copy to clipboard operation
zebra copied to clipboard

Stop panicking in `MustUseOneshotSender`, send an error instead

Open teor2345 opened this issue 2 years ago • 0 comments

Motivation

In MustUseOneshotSender, Zebra panics when ClientRequests don't get answered by the connection code.

Sometimes that's a bug in Zebra, but sometimes it happens during shutdown anyway. So we don't want to panic when there is no response.

Designs

Stop panicking in MustUseOneshotSender:

  • make dropped ClientRequests send an error response on the request sender, instead of panicking
  • rename MustUseOneshotSender to ErrorOnDropSender

Related Work

This is part of:

  • #3263

We could design the request code so that the compiler always makes us return an answer, but that needs a separate ticket.

teor2345 avatar Jul 04 '22 02:07 teor2345