Pokemon-Showdown-Dex icon indicating copy to clipboard operation
Pokemon-Showdown-Dex copied to clipboard
verified publisher icon Zarel

Show more type effectiveness info (closes #10)

Open phantamanta44 opened this issue 11 months ago • 0 comments

This PR:

  • Adds offensive type effectiveness to type pages
  • Reorganizes type effectiveness information into tables like this: steel type effectiveness tables
  • Adds defensive type effectiveness to Pokémon pages: Tinkaton defensive type effectiveness table

I will say that I don't very much like the use of PokedexTypePanel.prototype here: https://github.com/phantamanta44/Pokemon-Showdown-Dex/blob/52dfeb284c849df399b4871de85e552401c6e713/js/pokedex-pokemon.js#L80 However, I couldn't find any existing cases of rendering code shared between different panel types (aside from external rendering functions from the Showdown libs), so I wasn't sure how I should structure it.

phantamanta44 avatar Jan 13 '25 06:01 phantamanta44