dyc icon indicating copy to clipboard operation
dyc copied to clipboard

Published 20 hours ago • verified publisher icon Zarad1993

Added functionality to ignore Keywords in doctrings

Open srishtiganguly opened this issue 3 years ago • 5 comments

Reference Issue: #62 Keywords in docstring are not ignored

Changes added: Added few lines of code in the is_comment() and is_one_line_method() from utils.py & _get_name() from methods.py to handle content within docstrings to be considered as comments/docstrisngs.

srishtiganguly avatar Feb 28 '21 20:02 srishtiganguly

Hello @srishtiganguly - Thank you so much for your contribution. Feel free to ping me when this is ready to be reviewed.

Thanks again!

Zarad1993 avatar Mar 05 '21 16:03 Zarad1993

Hello @srishtiganguly - Thank you so much for your contribution. Feel free to ping me when this is ready to be reviewed.

Thanks again!

Hello @Zarad1993 , I have made the possible changes to the code and the code is ready for review. How do I check what check is failing in Travis CI?

srishtiganguly avatar Mar 08 '21 20:03 srishtiganguly

Hey @srishtiganguly - Sorry took a bit for me to look back. I think it is failing due to tox supporting 2.7 and 3.6 🤔

Zarad1993 avatar Mar 14 '21 21:03 Zarad1993

This is the error It's failing on 3.6 due to click dependency

Screen Shot 2021-03-14 at 11 05 28 PM

Zarad1993 avatar Mar 14 '21 21:03 Zarad1993

This is the error It's failing on 3.6 due to click dependency

Screen Shot 2021-03-14 at 11 05 28 PM

Thank you. Do I have to reinstall click == 7.0 and push the changes? Or would it work when you check on your system?

srishtiganguly avatar Mar 14 '21 21:03 srishtiganguly