AssistantPlus-Developer-Guide icon indicating copy to clipboard operation
AssistantPlus-Developer-Guide copied to clipboard

SpotifySearchCommands view issue

Open joemerlino opened this issue 9 years ago • 18 comments

Hi, i'm trying to compile your plugin and it works well if I play something but if I try to search for something, I can't tap any of the results that should brings me in spotify as your cydia version does. Can you help me figure out what's the problem? thanks in advance! img_1173 p.s. i'm trying all this to translate the plugin in Italian ;)

joemerlino avatar Apr 16 '15 14:04 joemerlino

When you select a cell does it get highlighted or does nothing at all happen? Are you able to scroll through the results?

ZaidElkurdi avatar Apr 16 '15 19:04 ZaidElkurdi

Nothing at all but i can scroll through the results @ZaidElkurdi ;)

joemerlino avatar Apr 16 '15 19:04 joemerlino

Same behaviour here using the Cydia version. I'm using spotify with a UK based premium subscription.

johnsibly avatar Apr 16 '15 19:04 johnsibly

i'm a premium too, maybe it's this the problem.

joemerlino avatar Apr 16 '15 19:04 joemerlino

I also have a premium subscription; it isn't a problem with Spotify. What devices are you using? And what SDK are you compiling with?

ZaidElkurdi avatar Apr 16 '15 19:04 ZaidElkurdi

iPhone 5,2 (iPhone 5) iOS 8.3

joemerlino avatar Apr 16 '15 19:04 joemerlino

I'm using an iPhone 5 with iOS 8.1.2. Actually the play command isn't working for me at the moment either (E.g. "Play songs by madonna on spotify"). Not sure if spotify have made a breaking change to their web service or App?

johnsibly avatar Apr 16 '15 20:04 johnsibly

i'm on iOS 8.1 but compiling with the 8.3 sdk, the play command works great on my end, it opens spotify and start playing automatically.

joemerlino avatar Apr 16 '15 20:04 joemerlino

I think the problem may actually be the iPhone 5. @johnsibly Try "Play Like a Prayer by Madonna on Spotify" or "Play Take me to Church on Spotify". The format is "Play [song name] on Spotify" or "Play [song name] by [artist name] on Spotify".

ZaidElkurdi avatar Apr 16 '15 20:04 ZaidElkurdi

@ZaidElkurdi you're right-user error on my part on the play command :) Still can't select results from a search though-does the plug in run as a 64-but binary on the 5S onwards? Could it be an issue around that?

johnsibly avatar Apr 16 '15 20:04 johnsibly

It may be a problem related to the architecture but you should receiving a lot of emails from iPhone 5/5c users describing the same issue. Plus, when I compiled the first time i received this error:

AFNetworking/AFOAuth2Manager.m:347:10: error: comparison of address of 'kSecAttrAccessibleWhenUnlocked' not equal to a null pointer is always true
  [-Werror,-Wtautological-pointer-compare]
if (&kSecAttrAccessibleWhenUnlocked != NULL) {
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~    ~~~~
1 error generated.

I deleted the if and now it compiles the deb just fine, but idk maybe it could be relevant for you. If you want i can install the same deb on my ipad mini 2 which is arm64 to see if it works or not.

joemerlino avatar Apr 16 '15 20:04 joemerlino

@johnsibly I think the problem is that I forgot armv7s in the Makefile, so it needs to be recompiled. I was planning on updating it anyway, so it should be fixed then.

@joemerlino The error you're getting is related to using 8.3 to compile it.

ZaidElkurdi avatar Apr 16 '15 22:04 ZaidElkurdi

Added iOS 8.1 sdk and it gives me the same error, deleted the if again, recompiled adding arm7s in the makefile but still I can't tap on any of the results. @ZaidElkurdi I think it's a problem with your custom nib view or something related to that. Hope you can fix this soon so i can publish my translated version ;)

joemerlino avatar Apr 21 '15 08:04 joemerlino

@joemerlino I understand that you want this fixed, and I am trying to fix it, but it's not as if I can snap my fingers and solve the issue. Have you tried debugging it yourself? Perhaps you could try removing the tableview and adding a UIButton to see if it's clickable. You'll see that that's not the case. Or, if you think it's the Nib that's the problem you could just change the cellForRowAtIndexPath: method to return a default UITableViewCell and see if that's selectable. You'll find that doesn't work either. I'm working on the issue and will push an update when I figure out the problem, but that doesn't mean you can't work on fixing it as well.

ZaidElkurdi avatar Apr 21 '15 20:04 ZaidElkurdi

i'm on it too ;) keep it easy. Thank you for the update.

joemerlino avatar Apr 21 '15 20:04 joemerlino

@ZaidElkurdi Firstly, thanks so much for this framework! I finally have a reason to learn objective-c! I have a similar issue with the git version related to the UITableView (BigBoss version works fine). The search results never appear and Siri crashes. I'm on a 6+ on 8.1.2, free spotify (no subscription).

*** Assertion failure in -[UITableView _configureCellForDisplay:forIndexPath:], /SourceCache/UIKit/UIKit-3318.16.21/UITableView.m:7344
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'UITableView dataSource must return a cell from tableView:cellForRowAtIndexPath:'

Pretty sure I didn't modify any of the code around the UITable stuff. Doesn't really bother me as I don't really use Spotify and I don't plan on using the UITableView with the plugin I'm developing. Anyway figured I'd let you know in case it helped with your debugging.

fritz-fritz avatar Apr 23 '15 21:04 fritz-fritz

@fritz-fritz i looked the entire plugin but found nothing that can fix this issue, compiled everything to armv7s and with the same original sdk still no luck...

joemerlino avatar May 17 '15 16:05 joemerlino

@ZaidElkurdi I have the exact same compile error as @joemerlino. I am using the 8.1 SDK and have armv7s in the make file. If I delete the if statement that causes that eror then I get more errors with AFURLConnectionOperation.m that say designated initializer invoked a non-designated initializer [-Werror,-Wobjc-designated-initializers]. Did you ever discover how to get it to compile correctly??

bdan629 avatar Jul 24 '15 15:07 bdan629