osm-relatify icon indicating copy to clipboard operation
osm-relatify copied to clipboard

No "Finish editing" button

Open MapperGaja opened this issue 1 year ago • 17 comments

I tried a route to edit, but I don't save/upload, because there is no blue Finish editing button. What can I do, or what I need to upload my edits?

MapperGaja avatar Sep 07 '23 11:09 MapperGaja

At the moment, the route must have no warnings or errors to be uploaded. You can view the current warnings on the menu on the left side (where the blue button will appear). If any of the warnings are unclear, please let me know so I can improve them. :slightly_smiling_face:

Zaczero avatar Sep 07 '23 11:09 Zaczero

Sorry, but this is all, what I see:

Relatify

Is there a warning? I can't see nothing...

MapperGaja avatar Sep 07 '23 13:09 MapperGaja

Oh, that's interesting. I'll take a look at this soon - hopefully today. Thank you for reporting this!

Zaczero avatar Sep 07 '23 13:09 Zaczero

The routing algorithm struggles to calculate this route and it times out. I have an idea on how to improve it but I haven't done so yet.

Zaczero avatar Sep 07 '23 13:09 Zaczero

OK. Thank you for your help!

MapperGaja avatar Sep 07 '23 13:09 MapperGaja

Would it be possible to enable the "download osc" option without clearing all errors? It can be frustrating if you have done some editing only to realise that the relevant stops are missing from OSM.

InsertUser avatar Sep 09 '23 10:09 InsertUser

Would it be possible to enable the "download osc" option without clearing all errors? It can be frustrating if you have done some editing only to realise that the relevant stops are missing from OSM.

There is a reload button in the top-right part of the menu for cases like these.

Zaczero avatar Sep 09 '23 11:09 Zaczero

Hi! Sorry, I'm in Vacation, so I don't read my e-mails regularly... So, I reload the relation an I have 'Finish edition' button, an I can save my modifications. But the representation of relation is not the same as other relations, it isn't drawn with broken line: kép An other relation from this island so: kép Is this a problem, or not?

MapperGaja avatar Sep 11 '23 13:09 MapperGaja

I don't see an end point in the first screenshot.

Dimitar5555 avatar Sep 11 '23 13:09 Dimitar5555

@MapperGaja It's very interesting; I'll investigate it. :slightly_smiling_face:

Zaczero avatar Sep 11 '23 13:09 Zaczero

I have troubles with relation 15949485, too. In OSM it seem OK. The OSM Relation Analyzer (http://ra.osmsurround.org/index) says "Great! This relation seems ok." Then, What's the problem???

MapperGaja avatar Sep 17 '23 12:09 MapperGaja

@MapperGaja I fixed some OSM tagging and Relatify seems to work well now: https://www.openstreetmap.org/changeset/141383370.

Zaczero avatar Sep 17 '23 14:09 Zaczero

Thank you for your work!

MapperGaja avatar Sep 17 '23 15:09 MapperGaja

Now (26th January 2024) is the same status with relation #6845924, as I saw on 11th September 2023 (see above): there is no moving stripes on the orange lines. What could be the problem?

MapperGaja avatar Jan 26 '24 15:01 MapperGaja

There are quite a few detours which slows down the pathfinding algorithm. Also, none of the turning loops have oneway tags. If they had, Relatify would've been able to find the proper route a bit faster.

Dimitar5555 avatar Jan 26 '24 16:01 Dimitar5555

Exactly! The missing moving stripes indicate a too complex path, and this is an algorithm limitation I am aware of. Currently, the interface lacks a clear "routing timeout" error message, which I am sorry for! It's definitely on my TODO list, but I am currently all-in on my OpenStreetMap NextGen project. If there are indeed oneway roads, marking them so would speed up calculation immensely. However, if there are not, then there is not much you can do than just edit the route using a different editor.

Zaczero avatar Jan 26 '24 16:01 Zaczero

OK, I understood. No problem. Thanks!

MapperGaja avatar Jan 26 '24 16:01 MapperGaja