mokuro-reader icon indicating copy to clipboard operation
mokuro-reader copied to clipboard

Update Svelte to the lasest verson

Open ZXY101 opened this issue 3 months ago • 6 comments

Vercel no longer supports node 18, the node version needs to be increased for deployments to continue but unfortunately the version of the Vercel adapter in use doesn't support node 20+, this is resolved in later versions of the adapter but to update we'd need to update svelte/kit/vite etc to the latest versions or try and patch the package.

ZXY101 avatar Sep 09 '25 19:09 ZXY101

I've already completed this on my fork. Should I make a PR for it to bring it back into yours? It has a lot of changes and improvements. I don't use any of the anki connect stuff. So if I broke that I wouldn't be able to spot it.

Gnathonic avatar Oct 17 '25 22:10 Gnathonic

@Gnathonic If possible that would be great, ideally cherry picking just the svelte changed to get this working. A lot of people use in anki integration so it wouldn't be great to have that broken

ZXY101 avatar Nov 01 '25 08:11 ZXY101

@ZXY101 If Anki support regressed. It would be easier to fix it then to cherry pick the svelte changes. I tried to get Anki connect working on my PC, but couldn't get it working even on your branch. So I've been working without testing it.

Is there some trick to get it working?

Gnathonic avatar Nov 01 '25 16:11 Gnathonic

@ZXY101 Got Ankiconnect working with your branch (I was expecting it to insert a card, which is why it never worked before).

Now I have it working on my branch as well. Updating to newer svelte caused some regressions. So even if we had cherry picked those changes, it still would have been broken.

Gnathonic avatar Nov 01 '25 21:11 Gnathonic

@Gnathonic Alright awesome stuff, can you drop me an email or discord or something. Wanna have a more direct convo about bringing in your fork into main.

ZXY101 avatar Nov 03 '25 18:11 ZXY101

@ZXY101 My discord user name is Gnathonic

Gnathonic avatar Nov 03 '25 20:11 Gnathonic